Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow error #543

Merged

Conversation

juliusgambe
Copy link

Changes

Close #533

Error Messages Changes

  • Included "and less than 2147483648" to ParseException
  • Included "and less than 2147483648" to invalid command format except DeliveryNote and DeliveryStatus

@juliusgambe juliusgambe marked this pull request as ready for review November 13, 2023 08:05
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4be29df) 84.35% compared to head (8c47993) 84.35%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #543   +/-   ##
=========================================
  Coverage     84.35%   84.35%           
  Complexity     1029     1029           
=========================================
  Files           121      121           
  Lines          3158     3158           
  Branches        370      370           
=========================================
  Hits           2664     2664           
  Misses          379      379           
  Partials        115      115           
Files Coverage Δ
...logic/commands/customer/CustomerDeleteCommand.java 83.33% <100.00%> (ø)
...s/logic/commands/customer/CustomerEditCommand.java 91.96% <ø> (ø)
...logic/commands/delivery/DeliveryDeleteCommand.java 83.87% <ø> (ø)
...s/logic/commands/delivery/DeliveryEditCommand.java 91.30% <100.00%> (ø)
...s/logic/commands/delivery/DeliveryViewCommand.java 81.25% <ø> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.51% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jianyangg jianyangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianyangg jianyangg merged commit 41014b5 into AY2324S1-CS2103T-T13-3:master Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Integer Overflow
2 participants