Fix Issues in Edit Command #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the EditCommand and EditCommandParser classes are inconsistent in that they contain methods that process patient attributes that are not parameters into the Edit command, or certain parts lack the processing of important attributes. Fixing this issue will prevent further bugs and lead to neater code. Let's, * Add and remove attributes in the two classes for consistency * Make sure that important attributes are mentioned in parts that were previously lacking them
There is an issue where after PatientBuilder() is called, it will call RecordBuilder(), which in turn calls PatientBuilder() again, causing a StackOverflow error. We need to fix this to get our test cases to pass. Let's * Add a new constructor to RecordBuilder that takes in a PatientBuilder to initialize its patient, instead of calling PatientBuilder again * Add new attributes to TypicalPatients Note that not all of the fields in Typical Patients are updated! AMY and BOB still need to be updated, which involves adding new attributes into CommandTestUtilgit add --all
The existing console messages do not display the new attributes, confusing the user as to what attributes are available. Adding them to the messages allow them to view all the patient's attributes even without the updated GUI. Let's update the Add command and patient messages.
thienmy0
approved these changes
Oct 18, 2023
Comment on lines
+27
to
+32
| .withName("Alice Pauline") | ||
| .withAddress("123, Jurong West Ave 6, #08-111") | ||
| .withEmail("alice@example.com") | ||
| .withGender("female") | ||
| .withBirthday("23/09/2000") | ||
| .withIcNumber("T0032415E") |
There was a problem hiding this comment.
I like how you adapted the TypicalPatients class to include our newly added fields!
There was a problem hiding this comment.
Agree with @thienmy0 on this point :)
Comment on lines
-16
to
+30
| import seedu.address.model.patient.*; | ||
| import seedu.address.model.patient.Address; | ||
| import seedu.address.model.patient.Birthday; | ||
| import seedu.address.model.patient.Email; | ||
| import seedu.address.model.patient.Gender; | ||
| import seedu.address.model.patient.IcNumber; | ||
| import seedu.address.model.patient.Name; | ||
| import seedu.address.model.patient.Patient; | ||
| import seedu.address.model.patient.Phone; |
There was a problem hiding this comment.
I like how you changed the import statements since * should be avoided!
| getTagSet("classmates")), new Patient(new Name("Roy Balakrishnan"), new Phone("92624417"), | ||
| new Email("royb@example.com"), new Gender("Male"), new IcNumber("t6789031q"), new Birthday("07/11/1976"), | ||
| new Address("Blk 45 Aljunied Street 85, #11-31"), getTagSet("colleagues"))}; | ||
| return new Patient[]{ |
There was a problem hiding this comment.
Shall we create constant variables for this (so when we modify the Patient constructor, it would be easier to update this class)?
longnguyentan
merged commit 1da5292
into
AY2324S1-CS2103T-T14-2:master
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issues in Edit Command
Fixed inconsistencies in attributes for EditCommand and EditCommandParser, as well as fixed a bug
Key changes
Made attributes utilized in Edit Command consistent
Fixed bug in PatientBuilder and RecordBuilder
Fixed Checkstyle Issues
NOTE: There are still 23 bugs to rectify... Guys, please remember to run checkstyle and test cases before pushing if you have not been doing so...