Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG with Assign Department Feature and Ui Component #137

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

wujy28
Copy link

@wujy28 wujy28 commented Oct 27, 2023

Update DG with Assign Department Feature

Included a new section under Implementation for Department and assign.
Also updated Ui Component section with new RecordPanel details

Key changes

Added the assign department feature to Implementation

  1. Added a section about how Department is implemented and its design considerations
  2. Added a section and sequence diagram for AssignCommand#execute

Update Ui Component section

  1. Updated the UML class diagram to include RecordCard and RecordPanel
  2. Updated the explanation

Currently the UI Component section of the developer guide
is outdated and missing information related to the
newly added RecordCard and RecordPanel classes.

Updating the guide can help us keep better documentation
of our project.

Let's add the newly added RecordPanel and RecordCard
classes to the UML diagram and alter the explanation
to include them as well.
The current developer guide lacks details regarding our
new features.

Updating it now would alleviate the burden of having
to do them later.

Let's add a section about how our department attribute
and assign department feature is implemented.
Currently there is placeholder text for the sequence diagram
for assign department in the implementation section.

Let's replace it with the actual diagram.
@wujy28 wujy28 added the type.Task Something that needs to be done, but not a story, bug, or an epic label Oct 27, 2023
@wujy28 wujy28 added this to the v1.3 milestone Oct 27, 2023
Copy link

@thienmy0 thienmy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice to see that you've updated the DG and added a diagram as well 👍

@thienmy0 thienmy0 merged commit 8ef8faa into AY2324S1-CS2103T-T14-2:master Oct 27, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants