Update DG #241
Merged
Update DG #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the DG lacks information about the implementation of newer commands such as sort. We should keep the DG up to date with its most recent implementation details. Let's, * Refine the assign command section of the DG * Add a section for the implementation of sort command.
Currently, some other components in the DG are outdated, with references to Person instead of Patient etc. They need to be updated so that it matches our project. Let's, * Change instances of 'Person' to 'Patient' * Update UML diagrams
thienmy0
approved these changes
Nov 11, 2023
Comment on lines
+448
to
+449
| 1. Name (lexicographically ascending, case-insensitive) | ||
| 2. IC Number (lexicographically ascending, case-insensitive) |
There was a problem hiding this comment.
Should we change this to be alphanumerical to be in line with our UG? 😅
|
|
||
| AddressBook *-right-> "1" UniquePersonList | ||
| Class Patient { |
There was a problem hiding this comment.
Thanks for updating the Model Class Diagram!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Updated DG with new section for sort command and also some other parts of DG
Key changes
Add section for Sort command
Change 'Person' to 'Patient' in other parts of DG