Update JsonAdaptedRecordTest #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update test cases for JsonAdaptedRecordTest and modify JsonAdaptedRecord.java. * Add JavaDocs to some files.
Update personal contribution to Project Portfolio Page (PPP).
AaronJT1
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Good job adding the java docs for the methods!!
Comment on lines
+65
to
+85
|
|
||
| @Override | ||
| public boolean equals(Object other) { | ||
| if (this == other) { | ||
| return true; | ||
| } | ||
| if (other == null || getClass() != other.getClass()) { | ||
| return false; | ||
| } | ||
| JsonAdaptedRecord that = (JsonAdaptedRecord) other; | ||
| return Objects.equals(patient, that.patient) | ||
| && Objects.equals(initialObservations, that.initialObservations) | ||
| && Objects.equals(diagnosis, that.diagnosis) | ||
| && Objects.equals(treatmentPlan, that.treatmentPlan); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(patient, initialObservations, diagnosis, treatmentPlan); | ||
| } | ||
|
|
Comment on lines
+38
to
+51
| // Test with empty strings | ||
| JsonAdaptedRecord jsonAdaptedRecord = new JsonAdaptedRecord( | ||
| expectedPatient, "", "", ""); | ||
|
|
||
| // Execution | ||
| Record modelRecord = jsonAdaptedRecord.toModelType(); | ||
|
|
||
| // Verification | ||
| assertEquals(expectedPatient, modelRecord.getPatient()); | ||
| assertEquals("", modelRecord.getInitialObservations()); | ||
| assertEquals("", modelRecord.getDiagnosis()); | ||
| assertEquals("", modelRecord.getTreatmentPlan()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I like how you used the comments to guide developers on the different logics of the method. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update JsonAdaptedRecordTest
Key changes