Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update untake feature in UG #204

Merged

Conversation

jingyu987
Copy link

Updated misleading information, didn't change the testers point of rephrasing "Existing stock will be increase..." as it doesnt really make sense to me.

@jingyu987 jingyu987 added type.Bug A bug priority.High Must do type.Documentation Improvements or additions to documentation and removed type.Bug A bug labels Nov 4, 2023
@jingyu987 jingyu987 linked an issue Nov 4, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38f9d32) 68.17% compared to head (c29fe13) 68.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #204   +/-   ##
=========================================
  Coverage     68.17%   68.17%           
  Complexity      569      569           
=========================================
  Files            97       97           
  Lines          2121     2121           
  Branches        254      254           
=========================================
  Hits           1446     1446           
  Misses          581      581           
  Partials         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ChongWeiJie29 ChongWeiJie29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChongWeiJie29 ChongWeiJie29 merged commit 2f0e78a into AY2324S1-CS2103T-T15-2:master Nov 5, 2023
5 checks passed
@jingyu987 jingyu987 added this to the v1.4 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] Explanation of the untake feature is confusing
3 participants