Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #209

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Improve tests #209

merged 3 commits into from
Nov 6, 2023

Conversation

TeeRenJing
Copy link

No description provided.

@TeeRenJing TeeRenJing added type.Task Something that needs to be done, but not under other labels priority.High Must do labels Nov 5, 2023
@TeeRenJing TeeRenJing added this to the v1.4 milestone Nov 5, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9305574) 70.31% compared to head (9a932c0) 72.32%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
+ Coverage     70.31%   72.32%   +2.01%     
- Complexity      587      604      +17     
============================================
  Files            97       97              
  Lines          2122     2125       +3     
  Branches        254      254              
============================================
+ Hits           1492     1537      +45     
+ Misses          540      498      -42     
  Partials         90       90
Files Coverage Δ
...u/address/logic/commands/ListConflictsCommand.java 100.00% <100.00%> (+100.00%) ⬆️
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <100.00%> (+100.00%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChongWeiJie29
ChongWeiJie29 approved these changes Nov 5, 2023
View reviewed changes
Copy link

@ChongWeiJie29 ChongWeiJie29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shyanyong
shyanyong approved these changes Nov 5, 2023
View reviewed changes
Copy link

@shyanyong shyanyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoeReRe RoeReRe merged commit ae3c336 into AY2324S1-CS2103T-T15-2:master Nov 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyanyong shyanyong shyanyong approved these changes

@ChongWeiJie29 ChongWeiJie29 ChongWeiJie29 approved these changes

Assignees

@shyanyong shyanyong

@ChongWeiJie29 ChongWeiJie29

@RoeReRe RoeReRe

@jingyu987 jingyu987

Labels
priority.High Must do type.Task Something that needs to be done, but not under other labels
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TeeRenJing @shyanyong @ChongWeiJie29 @RoeReRe @jingyu987