Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all errors in UG and amended DG #211

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

LHeng1
Copy link

@LHeng1 LHeng1 commented Nov 13, 2023

Closes #123

This PR amends both the UG and DG.

UG:

  • Grammatical errors
  • Formatting errors
  • Full stops
  • Checked expected output and error messages
  • Scrolled through every single "
    " to find the one missing closer
  • Some of the prefixes were missing
  • Signs of addressbook

DG:

  • Realized that Interview Score also can accept more than 2dp so added in the planned enhancements part

@LHeng1 LHeng1 requested a review from a team November 13, 2023 20:26
@LHeng1 LHeng1 added this to the v1.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #211 (b890f94) into master (5e500f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage     74.65%   74.65%           
  Complexity      666      666           
=========================================
  Files           107      107           
  Lines          2371     2371           
  Branches        247      247           
=========================================
  Hits           1770     1770           
  Misses          515      515           
  Partials         86       86           

Copy link

@ravern ravern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravern ravern merged commit bf3389d into AY2324S1-CS2103T-W10-1:master Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] Issues with neatness of UG
2 participants