Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic UI for compare function #93

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

LHeng1
Copy link

@LHeng1 LHeng1 commented Oct 25, 2023

Closes #94

This PR adds the minimum requirements of a UI needed for the compare function.

photo_2023-10-26_01-46-33

@LHeng1 LHeng1 requested a review from a team October 25, 2023 18:09
@LHeng1 LHeng1 added this to the v1.3 milestone Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #93 (1146a74) into master (31c3353) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
- Coverage     73.45%   72.82%   -0.64%     
  Complexity      555      555              
============================================
  Files           100      101       +1     
  Lines          1959     1976      +17     
  Branches        183      182       -1     
============================================
  Hits           1439     1439              
- Misses          464      481      +17     
  Partials         56       56              
Files Coverage Δ
...a/seedu/address/logic/commands/CompareCommand.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/CompareWindow.java 0.00% <0.00%> (ø)

Copy link

@ravern ravern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHeng1 LHeng1 merged commit 9c1c066 into AY2324S1-CS2103T-W10-1:master Oct 27, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement UI for compare function
2 participants