Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare function implementation details to DG #95

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

LHeng1
Copy link

@LHeng1 LHeng1 commented Oct 26, 2023

This PR adds a detailed guide on how the compare function was implemented to the Developer's Guide.

@LHeng1 LHeng1 requested a review from a team October 26, 2023 18:05
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #95 (0d8d252) into master (31c3353) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #95   +/-   ##
=========================================
  Coverage     73.45%   73.45%           
  Complexity      555      555           
=========================================
  Files           100      100           
  Lines          1959     1959           
  Branches        183      183           
=========================================
  Hits           1439     1439           
  Misses          464      464           
  Partials         56       56           

Copy link

@nabonitasen nabonitasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LHeng1 LHeng1 merged commit fba375f into AY2324S1-CS2103T-W10-1:master Oct 27, 2023
5 checks passed
@LHeng1 LHeng1 added this to the v1.3 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants