Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findprop feature #113

Merged

Conversation

nicolengk
Copy link

No description provided.

@nicolengk nicolengk added type.Story A user story priority.High Must do labels Oct 30, 2023
@nicolengk nicolengk added this to the v1.3 milestone Oct 30, 2023
@nicolengk nicolengk self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 92.59% <ø> (ø)
...du/address/logic/commands/FindPropertyCommand.java 100.00% <100.00%> (ø)
...el/property/PropNameContainsKeywordsPredicate.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 78.57% <0.00%> (ø)
...ddress/logic/parser/FindPropertyCommandParser.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@@ -18,6 +18,8 @@
import seedu.address.logic.commands.EditPropertyCommand;
import seedu.address.logic.commands.ExitCommand;
import seedu.address.logic.commands.FilterCustomerCommand;
import seedu.address.logic.commands.FindCommand;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be deleted?

Copy link

@Chrainx Chrainx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicolengk nicolengk merged commit 160b0e2 into AY2324S1-CS2103T-W11-2:master Oct 31, 2023
3 checks passed
@nicolengk nicolengk linked an issue Nov 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a property agent, I can find properties
2 participants