Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter properties command #114

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Add filter properties command #114

merged 5 commits into from
Oct 31, 2023

Conversation

FerdiHS
Copy link

@FerdiHS FerdiHS commented Oct 31, 2023

No description provided.

@FerdiHS FerdiHS added the priority.High Must do label Oct 31, 2023
@FerdiHS FerdiHS added this to the v1.3 milestone Oct 31, 2023
@FerdiHS FerdiHS self-assigned this Oct 31, 2023
@FerdiHS FerdiHS changed the title Filter property Add filter properties command Oct 31, 2023
@FerdiHS FerdiHS added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 31, 2023
@FerdiHS FerdiHS linked an issue Oct 31, 2023 that may be closed by this pull request
As a busy property agent, I can filter properties #72
Closed
4 tasks
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...ress/logic/parser/FilterCustomerCommandParser.java 100.00% <ø> (ø)
...ress/logic/parser/FilterPropertyCommandParser.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 78.57% <0.00%> (-2.92%) ⬇️
.../address/logic/commands/FilterPropertyCommand.java 95.34% <95.34%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

nicolengk
nicolengk approved these changes Oct 31, 2023
View reviewed changes
Copy link

@nicolengk nicolengk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FerdiHS FerdiHS merged commit 9195ba0 into AY2324S1-CS2103T-W11-2:master Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolengk nicolengk nicolengk approved these changes

Assignees

@FerdiHS FerdiHS

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

As a busy property agent, I can filter properties
2 participants
@FerdiHS @nicolengk