Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadMe #328

Merged
Merged

Conversation

owenyeo
Copy link

@owenyeo owenyeo commented Nov 13, 2023

ReadMe was outdated with wrong info about TimetaBRO. Outdated methods that were not used were present as well.

Fix README.md to reflect changes, and delete redundant methods.

ReadMe was outdated with wrong info about TimetaBRO. Outdated
methods that were not used were present as well.

Fix README.md to reflect changes, and delete redundant methods.
@owenyeo owenyeo added bug Something isn't working documentation Improvements or additions to documentation labels Nov 13, 2023
@owenyeo owenyeo added this to the v1.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #328 (a1f5f3b) into master (1cf0000) will decrease coverage by 0.32%.
Report is 22 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #328      +/-   ##
============================================
- Coverage     75.74%   75.42%   -0.32%     
- Complexity      968      970       +2     
============================================
  Files           110      110              
  Lines          3030     3052      +22     
  Branches        358      367       +9     
============================================
+ Hits           2295     2302       +7     
- Misses          648      660      +12     
- Partials         87       90       +3     
Files Coverage Δ
...java/seedu/address/model/person/timetable/Cca.java 100.00% <ø> (ø)
...edu/address/model/person/timetable/DatedEvent.java 82.14% <ø> (-11.98%) ⬇️
...a/seedu/address/model/person/timetable/Module.java 94.11% <ø> (-0.33%) ⬇️

... and 1 file with indirect coverage changes

Copy link

@teozhengyang teozhengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teozhengyang teozhengyang merged commit 40db704 into AY2324S1-CS2103T-W12-4:master Nov 13, 2023
4 of 5 checks passed
@owenyeo owenyeo deleted the v1.4-fixreadme-0 branch November 13, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants