Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester D] Invalid number can be registered for view-history #104

Closed
soc-se-bot opened this issue Apr 6, 2024 · 0 comments · Fixed by #134
Closed

[PE-D][Tester D] Invalid number can be registered for view-history #104

soc-se-bot opened this issue Apr 6, 2024 · 0 comments · Fixed by #134
Assignees
@ChongXern @Kishen271828
Labels
bug Something isn't working priority.High
Milestone
v2.1

Comments

@soc-se-bot
Copy link

  • Enter add-inflow command, for example, add-inflow n/Salary a/5000 d/21/02/2024 t/1700 c/income
  • Enter view-history command with invalid n (n <= 0), for example, view-history n/0 w/chart or view-history n/-1 w/chart
  • The program does not throw any error and register it as a valid input, with 100% INCOME graph

image.png

Labels: type.FunctionalityBug severity.Low
original: edwardhumi/ped#7
@Kishen271828 Kishen271828 self-assigned this Apr 11, 2024
@Kishen271828 Kishen271828 added bug Something isn't working priority.High labels Apr 12, 2024
@Kishen271828 Kishen271828 added this to the v2.1 milestone Apr 12, 2024
@ChongXern ChongXern self-assigned this Apr 12, 2024
ChongXern added a commit to ChongXern/tp that referenced this issue Apr 12, 2024
@ChongXern
Fix issues AY2324S2-CS2113-F14-4#126, AY2324S2-CS2113-F14-4#104 and A…
a58ba23 
…Y2324S2-CS2113-F14-4#95
@ChongXern ChongXern linked a pull request Apr 12, 2024 that will close this issue
Fix issues #126, #104 and #95 #134
Merged
ChongXern added a commit that referenced this issue Apr 12, 2024
@ChongXern
Merge pull request #134 from ChongXern/master
dbde541 
Fix issues #126, #104 and #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChongXern ChongXern

@Kishen271828 Kishen271828

Labels
bug Something isn't working priority.High
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Fix issues #126, #104 and #95 ChongXern/tp
3 participants
@soc-se-bot @ChongXern @Kishen271828