You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I realised that there are a lot of changes to code ownership. Do consider using these notations to mark out your code.
Similar feedback to your peers, there seems to be some form of parsing in this method. Perhaps the parser class can take care of it.
Please take a look at Single Responsibility Principle and cohesion regarding the class design choices.
Perhaps you might want to consider looking at past tp or AB3 for reference.
Similar to Point 2
The parser is doing switch statements and also doing error catching. Perhaps you might consider putting it together with the parser? This is so that there would be only one reason to change the functions.
The text was updated successfully, but these errors were encountered:
I realised that there are a lot of changes to code ownership. Do consider using these notations to mark out your code.
Similar feedback to your peers, there seems to be some form of parsing in this method. Perhaps the parser class can take care of it.
Please take a look at Single Responsibility Principle and cohesion regarding the class design choices.
Perhaps you might want to consider looking at past tp or AB3 for reference.
The parser is doing switch statements and also doing error catching. Perhaps you might consider putting it together with the parser? This is so that there would be only one reason to change the functions.
The text was updated successfully, but these errors were encountered: