Skip to content

Commit

Permalink
Acknowledgement
Browse files Browse the repository at this point in the history
  • Loading branch information
JeffinsonDarmawan committed Apr 15, 2024
1 parent 9e16963 commit 08abaa7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 15 deletions.
10 changes: 3 additions & 7 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Developer Guide

## Acknowledgements

{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}
Florizz implemented a third-party JTextUtil ASCII-Table library to create ASCII tables for the `help`, `compare` and `info`
command. The library can be found at [ASCII-Table GitHub Page](https://github.com/freva/ascii-table).

## Design
Florizz consists of four components, Ui, Logic, Model and Storage. These components are all called on by the Main component, Florizz.java, which simply handles the app initialisation.
Expand Down Expand Up @@ -203,8 +203,4 @@ Main Success Scenario (MSS):
- 2a. There are less than 5 stalks of rose in the specified bouquet
- 2a1. Florizz shows an error message

Use case ends.

**Acknowledgements**
Florizz implemented a third-party JTextUtil ASCII-Table library to create ASCII tables for the `help`, `compare` and `info`
command. The library can be found at [ASCII-Table GitHub Page](https://github.com/freva/ascii-table).
Use case ends.
16 changes: 8 additions & 8 deletions docs/team/jeffinsondarmawan.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,26 +63,26 @@ Code Contribution: [Jeffinson Darmawan RepoSense Report](https://nus-cs2113-ay23
This feature required the implementation of a new command and the creation of a new class to handle the comparison of two flowers.
It also uses an ASCII table to increase readability of the comparison results.

**Enhancements:**
1. Applying appropriate exceptions to ensure valid integer inputs in all commands involving integers
**Enhancements to Existing Features:**
- Applying appropriate exceptions to ensure valid integer inputs in all commands involving integers
(Pull Request [#166](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/166))
2. Added price information to bouquets (Pull Request [#65](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/65))
3. Improving Parser class by applying FuzzyLogic.detectItem()
- Added price information to bouquets (Pull Request [#65](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/65))
- Improving Parser class by applying FuzzyLogic.detectItem()
(Pull Request [#71](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/71))
4. Wrote JUnit tests for `AddFlowerCommandTest`, `HelpTest`, `InfoCommandTest`, `ListOccasionCommandTest`,
- Wrote JUnit tests for `AddFlowerCommandTest`, `HelpTest`, `InfoCommandTest`, `ListOccasionCommandTest`,
`RemoveFlowerCommandTest`, `FuzzyLogicTest`, `ParserTest`, `CompareCommandTest`
and wrote additional JUnit tests for `AddBouquetTest`,
`DeleteBouquetTest` which increases classes coverage from 54% to 63% and lines coverage from 29% to 51%.

**Documentation**
1. Developer Guide
- Developer Guide
(Pull Request [#82](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/82), [#180](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/180))
- Added UML diagrams and implementation details for `compare`, `remove` and `help`
2. User Guide
- User Guide
(Pull Request [#106](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/106))
- Added documentation on `compare` and `Fuzzy Logic`
- Updated documentation on `help`, `new`, `add` and `remove`

**Tools**
1. Integrated a third party JTextUtil ascii-table library to create ASCII tables for the `help`, `info`
- Integrated a third party JTextUtil ascii-table library to create ASCII tables for the `help`, `info`
and `compare` commands. (Link to GitHub Page: [ASCII-Table GitHub Page](https://github.com/freva/ascii-table)).

0 comments on commit 08abaa7

Please sign in to comment.