Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samuel v2.5 #167

Closed
wants to merge 4 commits into from
Closed

Samuel v2.5 #167

wants to merge 4 commits into from

Conversation

samuelory
Copy link

No description provided.

@samuelory samuelory added type.Bug A bug priority.Low Unlikely to do labels Apr 11, 2024
JeffinsonDarmawan
JeffinsonDarmawan reviewed Apr 11, 2024
View reviewed changes
Copy link

@JeffinsonDarmawan JeffinsonDarmawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this issue has been fixed before hand, and the most updated code in master already uses the firstSlash to parse flowers with two words.

image

@samuelory
Copy link
Author

Yeah i realised after i sent in the pull request that the issue was fixed, resolved the merge conflict alr

@samuelory samuelory closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffinsonDarmawan JeffinsonDarmawan JeffinsonDarmawan left review comments

Assignees
No one assigned
Labels
priority.Low Unlikely to do type.Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelory @JeffinsonDarmawan