Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated ppp #183

Merged
merged 2 commits into from
Apr 15, 2024
Merged

updated ppp #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a00fef1
updated ppp
IanFH Apr 15, 2024
eae1890
checkstyle
IanFH Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/team/ianfh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,18 @@ Click [here](https://nus-cs2113-ay2324s2.github.io/tp-dashboard/?search=ianfh&so

### Contributions to the DG
- Responsible for the add flower command sequence diagram and descriptions [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/78/files)
- Responsible for proposed storage implementation for DG draft [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/78/files)
- Responsible for proposed storage implementation and storage class diagram for DG draft [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/78/files)
- Responsible for recommend command sequence diagram and descriptions [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/178/files)
- Responsible for askOccasion sequence diagram and description [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/178/files)
- Responsible for Appendix of product scope, value proposition, user stories, and use cases [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/72/files)
- Updated info command, remove flower command sequence diagram based on TA's feedback [proof](https://github.com/AY2324S2-CS2113-T11-3/tp/pull/169/files)

#### Diagram Added
![Add Flower Command Diagram](../UML-diagrams/Ijaaz/AddFlowerCommand.png)
![Recommend Command Sequence Diagram](../UML-diagrams/Ian/RecommendCommand.png)
![askOccasion Sequence Diagram](../UML-diagrams/Ian/askOccasion.png)
![Unused storage class diagram](../UML-diagrams/Ian/storage.png)

### Contributions to Team-based Tasks
- Helped to set up the issue tracker for the team (i.e. milestones, tagging)

Expand Down
1 change: 0 additions & 1 deletion src/test/java/florizz/core/ParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

class ParserTest {
Expand Down
Loading