Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #116

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Fix bug #116

merged 4 commits into from
Apr 1, 2024

Conversation

daryltay415
Copy link

closes #115

@daryltay415 daryltay415 added the type.Enhancement An enhancement to an existing story label Apr 1, 2024
@daryltay415 daryltay415 added this to the v2.0b milestone Apr 1, 2024
TravelActivity activity;
switch (type) {
case "accommodation":
activity = new Accommodation(description, date, duration, tag);
activity = new Accommodation(description, date, duration, tag, expense);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding expense

@@ -85,4 +85,16 @@ public static void printDateTimeExceptionError(){
public static void printSavingError(){
System.out.println("Something went wrong when saving the file");
}

public static void printActivity(TravelActivity activity, int foundCounter) {
String checked = activity.getActivityStatus()? "[X]" : "[ ]";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good use of SLAP

} else if (type.equals("Landmark") && travelActivities.get(iterator) instanceof Landmark &&
!travelActivities.get(iterator).toString().isEmpty()) {
isFound = true;
foundCounter += 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of SLAP

@daryltay415 daryltay415 merged commit 3d46a95 into AY2324S2-CS2113-T12-4:master Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List and expense bug
2 participants