forked from nus-cs2113-AY2324S2/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch tag list #193
Merged
EugeneChanJiajun
merged 4 commits into
AY2324S2-CS2113-T12-4:master
from
daryltay415:branch-tag-list
Apr 6, 2024
Merged
Branch tag list #193
EugeneChanJiajun
merged 4 commits into
AY2324S2-CS2113-T12-4:master
from
daryltay415:branch-tag-list
Apr 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # omni.txt # src/main/java/seedu/omnitravel/errorhandlers/CheckParameters.java # src/main/java/seedu/omnitravel/parser/Parser.java # src/test/java/seedu/omnitravel/OmniTravelTest.java
This was
linked to
issues
Apr 6, 2024
[PE-D][Tester E] Only exact match of travel activity type is recognised in the findtype command
#182
Closed
EugeneChanJiajun
approved these changes
Apr 6, 2024
* Checks if a string contains all the words | ||
* @param input The input String | ||
*/ | ||
public static void containsWords(String input) throws OmniException{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job in identifying the keywords for duration
* @param list The travel activity list | ||
* @throws OmniException Throws an exception when the command is in an invalid format | ||
*/ | ||
public static void listTagsCommand(String[] command, TravelActivityList list) throws OmniException{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
EugeneChanJiajun
approved these changes
Apr 6, 2024
EugeneChanJiajun
merged commit Apr 6, 2024
162066f
into
AY2324S2-CS2113-T12-4:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.