finished list /date /sort #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annnniexu
requested review from
ChinYanXu,
EugeneChanJiajun,
ChenKangg and
daryltay415
daryltay415
approved these changes
Apr 11, 2024
| int finalActivityCount = noOfActivities; | ||
| assert finalActivityCount == activityCount : "Index out of bounds while listing activities"; | ||
| assert finalActivityCount >= activityCount : "Index out of bounds while listing activities"; |
There was a problem hiding this comment.
This assertion will cause it to fail as it will check that finalActivityCount >= activityCount. Since that is false it will cause the assertion to happen
| @@ -42,6 +52,18 @@ public void loadFileContents(TravelActivityList list) throws FileNotFoundExcepti | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| */ | ||
| public void listTravelActivities(){ | ||
| public void listTravelActivities(boolean sort, boolean filterDate, LocalDate date){ |
There was a problem hiding this comment.
Good enhancement to the current list feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.