Add new exceptions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daryltay415
requested review from
EugeneChanJiajun,
ChinYanXu,
ChenKangg and
annnniexu
EugeneChanJiajun
approved these changes
Mar 17, 2024
| @@ -20,7 +20,7 @@ public void addTravelActivity(TravelActivity travelActivity){ | |||
| travelActivities.add(travelActivity); | |||
| noOfTasks += 1; | |||
| int newSize = noOfTasks; | |||
| assert newSize != initialListSize + 1 : "There is an error with list size!"; | |||
| assert newSize == initialListSize + 1 : "There is an error with list size!"; | |||
There was a problem hiding this comment.
Good job in catching this assertion bug
| public static void main(String[] args) { | ||
| new Duke().runBot(); | ||
| Ui.printGreeting(); |
There was a problem hiding this comment.
Good job in cleaning up the code
| @@ -35,6 +37,16 @@ public static void printLine(){ | |||
| System.out.println("____________________________________________________________"); | |||
| } | |||
|
|
|||
| public static void printException(OmniException exception){ | |||
daryltay415
merged commit 87ed3d1
into
AY2324S2-CS2113-T12-4:master
0 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.