Refactor if-else statements with switch-case

AY2324S2-CS2113-T15-2 · Mar 13, 2024 · c04f08e · c04f08e
1 parent 301dbfb
commit c04f08e
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/src/main/java/parser/Parser.java b/src/main/java/parser/Parser.java
@@ -9,16 +9,24 @@ public class Parser {
     public Transaction parseTransaction(String input) {
         String data = input.substring(ADD_COMMAND_INDEX + 1);
         String[] parseData = data.split("/");
-        String description = null, date = null, amount = null, category = null;
+        String description = null;
+        String date = null;
+        String amount = null;
+        String category = null;
         for(int i = 0; i < parseData.length; i++) {
-            if (parseData[i].trim().equals("n")){
+            switch (parseData[i].trim()) {
+            case "n":
                 description = parseData[i + 1];
-            } else if (parseData[i].trim().equals("$")) {
+                break;
+            case "$":
                 amount = parseData[i + 1];
-            } else if (parseData[i].trim().equals("d")) {
+                break;
+            case "d":
                 date = parseData[i + 1];
-            } else if (parseData[i].trim().equals("c")) {
+                break;
+            case "c":
                 category = parseData[i + 1];
+                break;
             }
         }
         assert amount != null;