Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97 close insights window before exit #125

Conversation

Vavinan
Copy link

@Vavinan Vavinan commented Apr 8, 2024

This update closes all the insights window when "bye" command is issued to BudgetBuddy, to ensure that the program exits smoothly.

@Vavinan Vavinan added this to the v2.1 milestone Apr 8, 2024
@Vavinan Vavinan added type.Bug A bug severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. labels Apr 8, 2024
Copy link

@ShyamKrishna33 ShyamKrishna33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vavinan Vavinan merged commit 078fbed into AY2324S2-CS2113-T15-2:master Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester D] Cannot properly close application if insight windows are open
2 participants