Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle negative amount for add transaction #135

Conversation

ShyamKrishna33
Copy link

Fixes #107 , Fixes #104

Copy link

@vibes-863 vibes-863 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

@@ -16,7 +17,7 @@ public class ParserTest {

@Test
public void testParseTransaction() throws InvalidTransactionTypeException, EmptyArgumentException,
InvalidCategoryException {
InvalidCategoryException, InvalidAddTransactionSyntax {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good handling of exceptions

@vibes-863 vibes-863 added this to the v2.1 milestone Apr 10, 2024
@ShyamKrishna33 ShyamKrishna33 merged commit e3d1a03 into AY2324S2-CS2113-T15-2:master Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] add command income [PE-D][Tester D] Expenses and Income can be negative values
2 participants