Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions and logging #166

Merged

Conversation

vibes-863
Copy link

No description provided.

@vibes-863 vibes-863 added this to the v2.1 milestone Apr 15, 2024
@vibes-863 vibes-863 self-assigned this Apr 15, 2024
Copy link

@ShyamKrishna33 ShyamKrishna33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

*/
private static void setupLogger() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with logging!

@vibes-863 vibes-863 merged commit c2be51e into AY2324S2-CS2113-T15-2:master Apr 15, 2024
3 checks passed
Copy link

@Vavinan Vavinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!!

fh.setLevel(Level.INFO);
logger.addHandler(fh);
} catch (IOException e) {
UserInterface.printLoggerSetupError();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on catching exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants