Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine print and get PastWeek and PastMonth transactions method #77

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

isaaceng7
Copy link

Combined the printPastWeekTransactions and printPastMonthTransactions into one function, printPastTransactions.
Combined the getPastWeekTransactions and getPastMonthTransactions into one function, getPastTransactions.
Fixes #42

Copy link

@vibes-863 vibes-863 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work at removing redundant code!

@isaaceng7 isaaceng7 merged commit 8af18f7 into AY2324S2-CS2113-T15-2:master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code Review] isaaceng7
2 participants