Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance site interface with CSS to more clearer and cleaner one, and minor site enhancements #58

Closed
wants to merge 6 commits into from
Closed

Enhance site interface with CSS to more clearer and cleaner one, and minor site enhancements #58

wants to merge 6 commits into from

Conversation

Git-Harshit
Copy link
Contributor

@Git-Harshit Git-Harshit commented Sep 2, 2020 •
edited
Loading

This commit adds improved looks to the light (non-dark) theme specifically, by lightening the background. Also, the theme toggler now indicates the current theme when toggled.
Alongside, the commit now sets clickable links for user profiles followers, following, public repositories, and starred content. It also adds two headings to user profile details: users GitHub Pages hosted website, and Bio (About User).
This PR is made in response to Issue #57.

Description

The updated code mainly aims at enhancing the site appearance, fixing issues like invisibility of darker text over darker section.
Also, it involves minor code and performance improvisations.

Resolves #57

Type of Change:

  • User Interface
  • Minor Code Refactoring and functionality enhancement.

Screenshots

Screenshots of the proposed changes compared with the current version.

Capture_Default-BG-Lightened

  • Here, you can see that the default theme is more lightened than before, which eases readability of black text over it, in light theme.

Capture_Light-BG-New-Looks

  • The Light Theme Background previously set now seems to be a good choice and a good fit for the light theme, visually better appealing than before.

Capture_Dark_Theme

  • Here's how the dark theme looks on home page. Also notice the text of theme toggler to be changed to dark theme.

Capture_Theme_Button_OnHover

  • This is the newer look of the theme toggler when hovered (placed a mouse over it) on home page.

Capture_Buttons_OnHover

  • This is the newer look of the buttons when hovered on home page.

Capture_Profile_Clickables

  • Check out the direct links that are made available for followers, following, repositories and stars tabs.

Profile_Comparison

  • Introducing optional column (named Custom Site)! Notice that it is visible only for those who have setup a custom site, hosted at their respective GitHub Page (In the image, it is available at 3rd row for the profile at right, whereas it isn't detected, and therefore the row is ommitted, for the profile at left).

For older versions, of the displayed snippets, please check out the current version (before this PR is merged) of the project.

Additional Note:

Please add relevant labels to issue #57 like CH20, enhancement, and others (if not yet added, @Aakansha99) before merging this PR against the issue. It is all set, thanks to the repo owner!

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests/screenshots(If any) that prove my fix is effective or that my feature works

@Git-Harshit
Update default looks to more clearer and cleaner ones, with enhanced …
a48da67 
…CSS | Minor Code Refactoriness

This commit adds more clarity to the light theme specifically, by lightening the background. Also, the theme toggler now indicates the current theme when toggled.
Alongside, the commit now sets links for users followers, following, public repositories, and starred content. It also adds two headings to user profile details: users GitHhub hosted website, and Bio (About User).
It also involves some minor code refactoriness.
@Git-Harshit Git-Harshit changed the title Update default looks to more clearer and cleaner ones, with enhanced CSS Enhance site interface to more clearer and cleaner one, with CSS Sep 2, 2020
@Aakansha99
Copy link
Owner

Please add screenshots for the same

@Git-Harshit
Copy link
Contributor Author

@Aakansha99, I have updated the PR description with added screenshots, and have also resolved a merge conflict with index.html file of base branch. Please have a look at it now.

@Git-Harshit Git-Harshit changed the title Enhance site interface to more clearer and cleaner one, with CSS Enhance site interface with CSS to more clearer and cleaner one, and minor site enhancements Sep 3, 2020
@Git-Harshit
Merge 'master' from https://github.com/Aakansha99/Github-Profile-Anal…
224fc87 
…yser | Index Page Code Refactoriness | Resolve Merge Conflicts
@Git-Harshit
Moved Background Images out of CSS folder | Loader dismissal enhancement
a0e8576 
Now, the loader will dismiss after maximum 6 seconds. (just handy in case of any slower internet error or console errors). Also, the three background images will be now available in home directory rather than the CSS directory.
Git-Harshit
Git-Harshit commented Sep 5, 2020
View reviewed changes
Copy link
Contributor Author

@Git-Harshit Git-Harshit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aakansha99 The PR for the repository is now all set to enhance the site performance.

On merging my changes with your current live code (as on 5 Sept., 2020), here's how the updated version may look like:
a

Rest all is same as in description.

Please look into the PR, and if everything looks perfect, then merge it into the main branch. For issues or anything other, please let me know!

@Git-Harshit
Copy link
Contributor Author

Please let me know if the PR could be accepted and merged with the base branch, I'll fix the branch conflicts, just again.
Else, feel free to close the PR.

@Pawansinghla
Copy link

please resolve these merge conflicts

@Git-Harshit Git-Harshit mentioned this pull request Sep 30, 2020
Closed
@Git-Harshit Git-Harshit closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The current theme needs visual tweaks and enhancements for a clearer and better interface.
3 participants
@Git-Harshit @Aakansha99 @Pawansinghla