-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HAR-100] Added dialog documentation, HTML and CSS #25
Conversation
docs/components/dialog.md
Outdated
## HTML Structure | ||
``` | ||
dialog (modifier) | ||
├── content content--90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon and main elements are missing in structure section.
scss/components/dialog.scss
Outdated
} | ||
} | ||
|
||
.dialog--success { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dialog modifiers needs to be directly after the original block.
scss/components/dialog.scss
Outdated
background-color: $color-success-30; | ||
color: $color-success-600; | ||
|
||
& .dialog__icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block modifiers in elements should be placed in the element.
Example
.dialog__icon {
fill: $color-info-500;
.dialog--success & {
fill: $color-success-600;
}
...
}
@romypetitjean Another small change for the HTML: Dialog and content should be a section, so you can start with an H1 and not be dependent on the parents. |
No description provided.