Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAR-100] Added dialog documentation, HTML and CSS #25

Merged
merged 6 commits into from
Feb 19, 2018

Conversation

romypetitjean
Copy link
Contributor

No description provided.

@romypetitjean romypetitjean requested a review from a team February 12, 2018 13:22
## HTML Structure
```
dialog (modifier)
├── content content--90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon and main elements are missing in structure section.

}
}

.dialog--success {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog modifiers needs to be directly after the original block.

background-color: $color-success-30;
color: $color-success-600;

& .dialog__icon {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block modifiers in elements should be placed in the element.

Example

.dialog__icon {
	fill: $color-info-500;

	.dialog--success & {
		fill: $color-success-600;
	}

	...
}

@bartvandebiezen
Copy link
Contributor

bartvandebiezen commented Feb 13, 2018

@romypetitjean Another small change for the HTML: Dialog and content should be a section, so you can start with an H1 and not be dependent on the parents.

@edgargressie edgargressie merged commit 47d8f37 into develop Feb 19, 2018
@edgargressie edgargressie deleted the feature/HAR-100-dialog-component branch February 19, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants