Skip to content

Commit

Permalink
fix: remove unnecessary feature_name from group specs
Browse files Browse the repository at this point in the history
  • Loading branch information
MartinBernstorff committed Jun 13, 2023
1 parent 2008154 commit f29d017
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions src/timeseriesflattener/feature_spec_objects.py
Original file line number Diff line number Diff line change
Expand Up @@ -797,11 +797,6 @@ class Doc:
description="""Optional kwargs for the values_loader.""",
)

feature_name: str = Field(
description="""The name of the feature. Used for column name generation, e.g.
<prefix>_<feature_name>.""",
)

def _check_loaders_are_valid(self):
"""Check that all loaders can be resolved from the data_loaders catalogue."""
invalid_loaders: list = list(
Expand Down Expand Up @@ -914,9 +909,6 @@ class PredictorGroupSpec(_MinGroupSpec):
Prefix for column name, e,g, <prefix>_<feature_name>. Defaults to: pred.
loader_kwargs (Optional[List[Dict[str, Any]]]):
Optional kwargs for the values_loader.
feature_name (str):
The name of the feature. Used for column name generation, e.g.
<prefix>_<feature_name>.
lookbehind_days (List[float]):
How far behind to look for values
"""
Expand Down Expand Up @@ -970,9 +962,6 @@ class OutcomeGroupSpec(_MinGroupSpec):
Prefix for column name, e.g. <prefix>_<feature_name>. Defaults to: outc.
loader_kwargs (Optional[List[Dict[str, Any]]]):
Optional kwargs for the values_loader.
feature_name (str):
The name of the feature. Used for column name generation, e.g.
<prefix>_<feature_name>.
incident (Sequence[bool]):
Whether the outcome is incident or not, i.e. whether you
can experience it more than once. For example, type 2 diabetes is incident.
Expand Down Expand Up @@ -1037,9 +1026,6 @@ class TextPredictorGroupSpec(PredictorGroupSpec):
resolution, raise an error. Defaults to: [0.0].
prefix (str):
Prefix for column name, e,g, <prefix>_<feature_name>. Defaults to: pred.
feature_name (str):
The name of the feature. Used for column name generation, e.g.
<prefix>_<feature_name>.
loader_kwargs (Optional[List[Dict[str, Any]]]):
Optional kwargs for the values_loader.
lookbehind_days (List[float]):
Expand Down

0 comments on commit f29d017

Please sign in to comment.