forked from getumbrel/umbrel
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from getumbrel:master #17
Open
pull
wants to merge
2,010
commits into
AaronDewes:master
Choose a base branch
from
getumbrel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mayank Chhabra <mayankchhabra9@gmail.com>
Currently the Node.js process restarts on backend code changes, however since we introduced the Docker cleanup that nukes pre-running containers on umbreld startup, this means that live reload now causes all app containers to be cleaned up and then restarted which takes ages. We now just skip that step during development so we get fast live reload of the backend on code change.
Co-authored-by: Luke Childs <lukechilds123@gmail.com>
- Improve accuracy of CPU and memory calculations - Improve performance of disk calculations - Retry on failed app disk calculations - Show live usage in individual panes - Show overview with chart in preview pane Co-authored-by: Mayank Chhabra <mayankchhabra9@gmail.com>
Otherwise with a small amount of WiFi networks listed you are unable to scroll to the bottom entries
Adds a GitHub action that: - Goes over all UI files to remove any unused keys from all locale files - Checks for missing variables like {{name}} in non-english locales - Removes any keys in non-english locales that don't exist in english locale - Generates missing translations for non-english locales - Sorts all locales
Co-authored-by: Nathan Fretz <nmfretz@gmail.com>
Co-authored-by: Nathan Fretz <nmfretz@gmail.com>
Co-authored-by: Nathan Fretz <nmfretz@gmail.com>
Co-authored-by: Nathan Fretz <nmfretz@gmail.com>
Multipass dropped support for Ubuntu 23.10 base images which we had pinned to so the latest version of Multipass gave errors when trying to provision a VM saying that Ubuntu version didn't exist. After changing to the latest LTS 24.04 a VM could be created but the provision script failed to execute with a permission error. It looks like the way mounts work has totally changed in this version of Multipass because now all mounts are unable to be read inside the VM. You can't even fix it with permissions, even root cannot read the files and you can't chown/chmod etc. Multipass has another mount type called `native` (https://multipass.run/docs/mount#native-mounts) which works for me on Mac, however you can't specify this mount type at VM creation and also can't create this mount type while the VM is running. So we now, create the VM, wait for it to boot, then stop it, then setup the native mount, then start it again, then run the provision script. The provision script then fails because the version of Docker we use (25.0.4) does not exist in the Ubuntu 24.04 repos because that Ubuntu version came out after that Docker version. This was fixed by rolling the Ubuntu version back to the previous LTS version 22.04. This is now working for but since we've changed Ubuntu versions every single package on the system will now be a different version to what we've tested before. Also the native mount type acts differently on different systems and doesn't always work if the native platform doesn't support it. It's unclear how well this will work on other platforms but it appears to work well for me on arm macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )