Make DNNE build incrementally #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtschuster I fixed the workflows so the CI would work. Seems like there are some issues with these changes. Let me know if you want some help investigating them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSBuild is annoying and this is required to build incrementally. MSBuild will compare the oldest output to the newest input by default, and
dnne.hfrom the nuget package is always going to be older than the generated header, so it'll never build incrementally. We need to create a 1:1 mapping from input item to output item, but this can ONLY be done when the output property is a transformation of the input dotnet/msbuild#7021.All of the output filenames are the same except for
DnneGeneratedSourceFile. If we change that to$(DnneNativeExportsBinaryName).h(binaryname.h) instead of$(DnneGeneratedOutputPath)/$(TargetName).g.cwe could make it a bit simpler by avoiding the extra "OutputFileName" metadata.