Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect SupportedOSPlatformAttribute on exports. #83

Merged
merged 6 commits into from Sep 21, 2021
Merged

Conversation

AaronRobinsonMSFT
Copy link
Owner

Add tests for all currently defined .NET platforms.

Fixes #82

Add tests for all currently defined .NET platforms.
@AaronRobinsonMSFT
Copy link
Owner Author

@jkoritzinsky Could you do me a favor and give this a quick pass? I don't see any need for UnsupportedOSPlatformAttribute for native exporting but could be missing something.

@jkoritzinsky
Copy link
Collaborator

This generally looks good. I think implementing the whole spec for these attribute types would be useful, primarily for cases that might use some sort of underlying APIs that only work on some platforms (or to enable the UnmanagedCallersOnly method to use methods with UnsupportedOSPlatformAttribute in managed code and have that reflected properly in the native exports without causing analyzer diagnostics).

I'd suggest doing #ifndef for the "unsupported OS" cases, which should be pretty simple.

@AaronRobinsonMSFT
Copy link
Owner Author

I'd suggest doing #ifndef for the "unsupported OS" cases, which should be pretty simple.

Sigh... fine :-) It is simple for sure.

@AaronRobinsonMSFT
Copy link
Owner Author

I think implementing the whole spec for these attribute types would be useful

Ugh. This is more complicated since multiple are allowed.... boo.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 908b719 into master Sep 21, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the issue_82 branch September 21, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Honor SupportedOSPlatformAttribute when emitting .g.c file.
2 participants