Make updates to FishUntil

Implement nitpicks from akkadotnet#5430
Aaronontheweb · Dec 15, 2021 · b368dc6 · b368dc6
1 parent 7e48e35
commit b368dc6
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/src/core/Akka.TestKit/TestKitBase_Receive.cs b/src/core/Akka.TestKit/TestKitBase_Receive.cs
@@ -51,24 +51,27 @@ public T FishForMessage<T>(Predicate<T> isMessage, TimeSpan? max = null, string
                 var left = end - Now;
                 var msg = ReceiveOne(left);
                 _assertions.AssertTrue(msg != null, "Timeout ({0}) during fishForMessage{1}", maxValue, string.IsNullOrEmpty(hint) ? "" : ", hint: " + hint);
-                if (msg is T && isMessage((T)msg))
+                if (msg is T msg1 && isMessage(msg1))
                 {
-                    return (T)msg;
+                    return msg1;
                 }
             }
         }
 
         /// <summary>
-        /// Receives messages until <paramref name="max"/>. Ignores all messages except for a message of type <typeparamref name="T"/>. Asserts that all messages are not of the of type <typeparamref name="T"/>. Note that when comparing types, inheritance is ignored, in other words, only perfectly matching types are asserted.
+        /// Receives messages until <paramref name="max"/>.
+        ///
+        /// Ignores all messages except for a message of type <typeparamref name="T"/>.
+        /// Asserts that all messages are not of the of type <typeparamref name="T"/>.
+        /// Note that when comparing types, inheritance is ignored, in other words, only perfectly matching types are asserted.
         /// </summary>
         /// <typeparam name="T">The type that the message is not supposed to be.</typeparam>
-        /// <param name="probe"></param>
-        /// <param name="max"></param>
-        public async static Task InverseFishForMessage<T>(TestProbe probe, TimeSpan? max = null)
+        /// <param name="max">Optional. The maximum wait duration. Defaults to <see cref="RemainingOrDefault"/> when unset.</param>
+        public async Task FishUntilMessage<T>(TimeSpan? max = null)
         {
             await Task.Run(() =>
             {
-                probe.ReceiveWhile<object>(max: max, shouldIgnore: x =>
+                ReceiveWhile<object>(max: max, shouldIgnore: x =>
                 {
                     x.Should().NotBeOfType<T>();
                     return false; // we are not returning anything