Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sqlmain import all CSV methods from CSVManager. #25

Merged
merged 3 commits into from
Jun 20, 2020

Conversation

Aathish04
Copy link
Owner

Currently, sqlmain imports the csv module and uses a custom function to parse it for rows and fields.

def parseCSV(fp): #Why can't you use CSVManager.list_od_from_csv for this?

This has already been implemented as a method in CSVManager.

def records_from_csv(self,datafile=None):

In order to clean up the code and reduce the amount of unnecessary imports, I have removed the function, imported CSVManager, and used method in CSVManager to replace the function.

If this is merged, it would fix #19 .

@naveen521kk naveen521kk merged commit c8d750b into master Jun 20, 2020
@naveen521kk naveen521kk deleted the isolate-csv-sql branch June 20, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of CSV module from sqlmain.py
2 participants