Benchmarks moved out of test dir #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They no longer run with pytest. They are just python scripts. This is in preparation to make tests for the benchmark runners themselves that mock out just the OpenAi api. This change also has a number of small benefits: * The cli interface is simpler no longer requiring "pytest --benchmark -s test/" * We don't have to worry about pytest capturing or suppressing errors or standard out. * Some prompts wanted to be used in the scripts dir requiring tests to be a module. Not tests does not have to be one but benchmarks is.
PCSwingle
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They no longer run with pytest. They are just python scripts. This is in preparation to make tests for the benchmark runners themselves that mock out just the OpenAi api.
This change also has a number of small benefits:
I made sure benchmark_runner and the exercism benchmarks still work (you can test them with the commands in the readme) but some other benchmarks such as the context_benchmark seem a little broken at the moment. Which I guess shows the importance of testing.
Pull Request Checklist