Exercism benchmark test #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows the standard out has a trailing newline so our check if a test passed isn't correct.
jakethekoenig
commented
Jan 15, 2024
| @@ -26,7 +26,7 @@ def _run_test_command(self, command, cwd="."): | |||
| except subprocess.TimeoutExpired: | |||
| results = "Test timed out" | |||
| with open(self.test_output_file, "w") as f: | |||
| f.write(results) | |||
| f.write(results.strip()) | |||
There was a problem hiding this comment.
On windows the stdout had a trailing new line which messed with our pass/fail detection code.
biobootloader
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist