Benchmark runner test #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While writing this I made the following changes: * benchmark_repos was made a subdir of benchmarks so verify functions could import from generated code. Otherwise python complains it isn't part of a module. * In fact setup_repo does change the current directory. evalute_py and evaluate_sample now change the directory back. * The whole functions have a try now so spurious errors won't crash a run.
jakethekoenig
commented
Jan 16, 2024
| @@ -9,31 +9,33 @@ def test_empty_sequence(self): | |||
|
|
|||
| def test_pow(self): | |||
There was a problem hiding this comment.
We can't let the actual accumulate get formatted because it could make the saved gpt output invalid but I'm inclined to let our linter change the test.
granawkins
approved these changes
Jan 18, 2024
|
|
||
| [tool.ruff] | ||
| line-length = 120 | ||
| ignore = ["E731"] | ||
|
|
||
| [tool.pytest.ini_options] | ||
| addopts = "--ignore=vscode/bundled --ignore=benchmark_repos --ignore=testbed/exercism-python" | ||
| addopts = "--ignore=vscode/bundled --ignore=benchmarks/benchmark_repos --ignore=testbed/exercism-python" |
There was a problem hiding this comment.
Should also update pyrightconfig.json, change benchmark_repos to benchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing this I made the following changes:
It's a little less comprehensive than the exercism analogue but I think it'll still be valuable.
Pull Request Checklist