Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComfyUI] Missing progress bar in Sampler node (docker related) #428

Closed
2 tasks done
divens opened this issue Apr 28, 2023 · 0 comments
Closed
2 tasks done

[ComfyUI] Missing progress bar in Sampler node (docker related) #428

divens opened this issue Apr 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@divens
Copy link
Contributor

divens commented Apr 28, 2023

Has this issue been opened before?

  • It is not in the FAQ, I checked.
  • It is not in the issues, I searched.

Describe the bug

Normally when you run ComfyUI from a local install, you get a progress bar in the sampling node like in this screenshot:

image

When running ComfyUI from the container built with this repo, we don't get the progress bar

image

It comes down to an issue with tqdm which Comfy piggybacks on to pass the progress from server to client.

To fix it, you have to declare a tty on the comfy service (will open a PR for that).

Which UI

comfy

Hardware / Software

  • OS: Windows 11
  • OS version: 22H2 | 22621.1555
  • WSL version (if applicable): WSL2 / Ubuntu-22.04
  • Docker Version: Docker Desktop v4.18.0
  • Docker compose version: v2.17.2
  • Repo version: 076b574

Steps to Reproduce

git clone https://github.com/AbdBarho/stable-diffusion-webui-docker/
docker compose --profile download up --build
docker compose --profile comfy up --build
open browser to localhost:7860
click on "Queue Prompt" button (there is a default workflow when you open Comfy for the first time)
watch the green outline go from node to node and see there is no progress on Sample node

Additional context

For what it's worth, this can be sidestepped without change by using docker compose run instead of docker compose up, but then you get a new container every time, and you have to modify the compose command from what is in the documentation.

@divens divens added the bug Something isn't working label Apr 28, 2023
AbdBarho pushed a commit that referenced this issue Apr 28, 2023
Closes issue #428

Co-authored-by: Dylan Ivens <12586504+divens@users.noreply.github.com>
Jordan-Lambda pushed a commit to Jordan-Lambda/lambda-cloud-stable-diffusion-2.0-webui-easy that referenced this issue Aug 2, 2023
Closes issue AbdBarho#428

Co-authored-by: Dylan Ivens <12586504+divens@users.noreply.github.com>
cloudaxes pushed a commit to cloudaxes/stable-diffusion-webui-docker that referenced this issue Sep 6, 2023
Closes issue AbdBarho#428

Co-authored-by: Dylan Ivens <12586504+divens@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants