Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AMD for auto1111 #362

Closed
wants to merge 7 commits into from
Closed

Conversation

mtthw-meyer
Copy link

@AbdBarho
Copy link
Owner

AbdBarho commented Mar 10, 2023

Ok this is cool, but I cannot maintain the code like this, because the nvidia code would not work any more.

How can we organize this so that it works for both?

We probably need a new service.

@mtthw-meyer
Copy link
Author

Yeah. Still playing with it. Not done a nice integration pass.

@mtthw-meyer
Copy link
Author

Gonna try and get the other two working as well.

@mtthw-meyer mtthw-meyer marked this pull request as draft March 11, 2023 22:52
@mtthw-meyer mtthw-meyer marked this pull request as ready for review March 12, 2023 02:51
@mtthw-meyer
Copy link
Author

Added services for all 3. I as able to do a test generation in all of them.

group_add:
- video
devices:
- "/dev/dri"
Copy link

@zthxxx zthxxx Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work on Mac

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zthxxx linux only, I don't think this works for mac or windows either?
If someone actually figures out how to do this AMD setup with docker in windows, that would be really really awesome.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, no mac or windows handy to try with either.

@AbdBarho AbdBarho added the awaiting-response Waiting for the issuer to respond label Apr 3, 2023
@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 25, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this May 2, 2023
- video
devices:
- "/dev/dri"
- "/dev/kfd"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at getting this running within a docker container on windows but it seems like this does not exist on WSL yet and fails when I get to the last stage of running it.

Error response from daemon: error gathering device information while adding custom device "/dev/kfd": no such file or directory

"/dev/kfd: the main compute interface shared by all GPUs" from https://rocmdocs.amd.com/_/downloads/en/latest/pdf/

I might try getting this working on linux and open another merge request.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's unavailable for wsl + docker to use AMD gpus yet, right? @mpitropov any updates?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to get it working for wsl + docker on AMD. I made my own version of this branch for linux and AMD for AUTOMATIC111 by looking at their repository. I don't know a clean way of creating the code such that I should make a merge request since there are no if statements in docker files to run AMD or NVidia specific code.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtthw-meyer any thoughts? can your docker access the /dev/kfd device?

@flying-sheep flying-sheep mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Waiting for the issuer to respond Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants