Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/fix mounts for comfyUI #432

Merged
merged 6 commits into from May 7, 2023
Merged

Update/fix mounts for comfyUI #432

merged 6 commits into from May 7, 2023

Conversation

LEv145
Copy link
Contributor

@LEv145 LEv145 commented Apr 29, 2023

I updated the paths to make all paths work

Now paths in ComfyUI are working
Added:

  • input
  • models/configs
  • models/gligen
  • models/diffusers
  • models/hypernetworks

Was broken:

  • custom_nodes
  • models/clip_vision
  • models/clip

LEv145 and others added 3 commits April 27, 2023 18:59
Fix `custom_nodes` path
Move models for comfy from `/data/config/comfy` to `/data/config/comfy/models`
Add paths for models: `diffusers`, `gligen`, `hypernetworks`
Mode `clip`, `clip_vision` from cache to models, because it's model
Add path for `input` 
Format script for reading
@LEv145 LEv145 changed the title Update mounts for comfyUI Update/fix mounts for comfyUI Apr 29, 2023
Copy link
Owner

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we still need some tuning for this UI.


MOUNTS["${ROOT}/models/style_models"]="/data/config/comfy/models/style_models"
MOUNTS["${ROOT}/models/t2i_adapter"]="/data/config/comfy/models/t2i_adapter"
MOUNTS["${ROOT}/models/clip"]="/data/config/comfy/models/clip"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this any different from the standard clip model provided by the transformers packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes

MOUNTS["${ROOT}/models/clip"]="/data/config/comfy/models/clip"
MOUNTS["${ROOT}/models/clip_vision"]="/data/config/comfy/models/clip_vision"
MOUNTS["${ROOT}/models/gligen"]="/data/config/comfy/models/gligen"
MOUNTS["${ROOT}/models/diffusers"]="/data/config/comfy/models/diffusers"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

@LEv145
Copy link
Contributor Author

LEv145 commented May 1, 2023

I didn't really understand you, but comfyUI has nodes that use these models:

@LEv145
Copy link
Contributor Author

LEv145 commented May 2, 2023

@AbdBarho Did I make myself clear?

@AbdBarho
Copy link
Owner

AbdBarho commented May 6, 2023

I will try to test the clip model and others tomorrow, then we can merge this PR, sorry for the delay.

@PassiveLemon
Copy link
Contributor

What was broken about these? I never had to use them so I don't really know

@AbdBarho
Copy link
Owner

AbdBarho commented May 7, 2023

I changed the solution to something a bit more maintainable.

The commented lines are stuff I was not able to test, so I will delay for now. If you have examples of how I can test this stuff, hmu.

@AbdBarho AbdBarho merged commit d47e77f into AbdBarho:master May 7, 2023
@LEv145
Copy link
Contributor Author

LEv145 commented May 7, 2023

@PassiveLemon It was impossible to add custom nodes, or for example load your own clip for CLIPLoader node for CLIPTextEncode:
comfyanonymous/ComfyUI#25 (comment)

@LEv145
Copy link
Contributor Author

LEv145 commented May 7, 2023

@AbdBarho
You can also use this example for tests clip:
comfyanonymous/ComfyUI#25 (comment)

I don't think clip should be in .cache/clip, because a user downloads it separately

It may be more convenient to use config/comfy/models/style_models instead of config/comfy/style_models, because:

  1. This is how the folders are located in comfyUI
  2. It is more convenient to navigate
  3. ComfyUI appeared recently, so there is still time to change

@AbdBarho
Copy link
Owner

AbdBarho commented May 7, 2023

Thank you! I will try this example and see what need to be changed.

@PassiveLemon
Copy link
Contributor

@PassiveLemon It was impossible to add custom nodes, or for example load your own clip for CLIPLoader node for CLIPTextEncode: comfyanonymous/ComfyUI#25 (comment)

This actually means a lot to me. I was just working on a way to make nodes easier to install by automatically installing their requirements.txt when put into the custom_nodes directory. This would explain why it wasn't working, because now it does work lol

@AbdBarho AbdBarho mentioned this pull request May 8, 2023
@AbdBarho
Copy link
Owner

AbdBarho commented May 8, 2023

So the clip is just replacement for the clip that is usually part of the sd model, I see.

I created #458 for clip, I am unfortunately still unsure about the remaining stuff, I will checkout #451 next

I will try to find more examples for the remaining missing mounts, just so I can test them and integrate them.

AbdBarho added a commit that referenced this pull request May 8, 2023
Jordan-Lambda pushed a commit to Jordan-Lambda/lambda-cloud-stable-diffusion-2.0-webui-easy that referenced this pull request Aug 2, 2023
I updated the paths to make all paths work

Now paths in ComfyUI are working
Added: 
- `input`
- `models/configs`
- `models/gligen`
- `models/diffusers`
- `models/hypernetworks`

Was broken:
- `custom_nodes`
- `models/clip_vision` 
- `models/clip`

---------

Co-authored-by: LEv145 <you@example.com>
Co-authored-by: AbdBarho <ka70911@gmail.com>
Jordan-Lambda pushed a commit to Jordan-Lambda/lambda-cloud-stable-diffusion-2.0-webui-easy that referenced this pull request Aug 2, 2023
cloudaxes pushed a commit to cloudaxes/stable-diffusion-webui-docker that referenced this pull request Sep 6, 2023
I updated the paths to make all paths work

Now paths in ComfyUI are working
Added: 
- `input`
- `models/configs`
- `models/gligen`
- `models/diffusers`
- `models/hypernetworks`

Was broken:
- `custom_nodes`
- `models/clip_vision` 
- `models/clip`

---------

Co-authored-by: LEv145 <you@example.com>
Co-authored-by: AbdBarho <ka70911@gmail.com>
cloudaxes pushed a commit to cloudaxes/stable-diffusion-webui-docker that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants