-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ComfyUI #451
Update ComfyUI #451
Changes from 6 commits
5477b88
73f88f2
37150c5
1c129ee
3849c48
17c44ca
89092c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,4 +44,16 @@ for to_path in "${!MOUNTS[@]}"; do | |
echo Mounted $(basename "${from_path}") | ||
done | ||
|
||
if [ "$(ls -A /stable-diffusion/custom_nodes)" ]; then | ||
chmod 777 -R "/stable-diffusion/custom_nodes/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this necessary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Testing reasons. I wasn't going to bother fixing everything until there was a proposed solution |
||
apt-get install build-essential -y | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could move this into the dockerfile, where we install aria2 and others |
||
for dir in "/stable-diffusion/custom_nodes/*"; do | ||
if [ -e "$dir/requirements.txt" ]; then | ||
echo $dir | ||
cd $dir | ||
pip install -r requirements.txt | ||
fi | ||
done | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we could simplify this loop shopt -s nullglob
list=(${ROOT}/custom_nodes/*/requirements.txt)
for req in "${list[@]}"; do
pip install -r "$req"
done |
||
fi | ||
|
||
exec "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already mounted in the
x-base-service
, so there is no need to change the mounts here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the issue though. I know it's present in the base, but the save image node won't save the images to the hosts output directory unless it is present in the actual profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the output folder of the save image node? and does the
output/comfy
exist on your machine?