Modify installation extension dependencies #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform a full extension installation process instead of just installing dependencies
AbdBarho
reviewed
Jun 25, 2023
| pip install -r "$req" | ||
| list=(./extensions/*/install.py) | ||
| for installscript in "${list[@]}"; do | ||
| PYTHONPATH=${ROOT} python "$installscript" |
There was a problem hiding this comment.
oh I see, it is here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Developing-extensions#installpy
Would be great if you could add this as a comment
There was a problem hiding this comment.
Yes, from the results of my test, PYTHONPATH is necessary, otherwise some modules provided by the webui project will not be found correctly
sf666
added a commit
to sf666/sd
that referenced
this pull request
Jul 3, 2023
* Abd_master: Auto 1.4.0 (AbdBarho#507) Bump auto Add build-essential package (AbdBarho#522) Allow setting port through env WEBUI_PORT (AbdBarho#521) Create dirs if not exist (AbdBarho#520) Modify installation extension dependencies (AbdBarho#518) v8 (AbdBarho#516) # Conflicts: # data/.gitignore # docker-compose.yml
cloudaxes
pushed a commit
to cloudaxes/stable-diffusion-webui-docker
that referenced
this pull request
Sep 6, 2023
Perform a full extension installation process instead of just installing dependencies Some extensions do not include `requirements.txt` but install dependencies in `install.py`, and all extensions include `install.py`, so it is safe to use it for extended dependency installation This is because the extension development of AUTOMATIC1111's webui does not require the existence of `requirements.txt` but uses `install.py` to initialize the extension https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Developing-extensions#installpy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform a full extension installation process instead of just installing dependencies
Some extensions do not include
requirements.txtbut install dependencies ininstall.py, and all extensions includeinstall.py, so it is safe to use it for extended dependency installationThis is because the extension development of AUTOMATIC1111's webui does not require the existence of
requirements.txtbut usesinstall.pyto initialize the extensionhttps://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Developing-extensions#installpy