Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows version false positive after installing Windows 7 icon pack #164

Closed
Cynosphere opened this issue Jul 12, 2023 · 3 comments
Closed
Labels
bug Something isn't working issue Issue

Comments

@Cynosphere
Copy link

Describe the bug

WinPaletter thinks the OS is Windows 7 after applying a Windows 7 icon pack that modifies winver on Windows 10

WinPaletter Log

N/A

Screenshots/Screen records

N/A

Additional context

https://www.deviantart.com/luximoz/art/7TSP-UpdatedSevenifier-Winver-fix-970479301

@Cynosphere Cynosphere added bug Something isn't working issue Issue labels Jul 12, 2023
@Abdelrhman-AK
Copy link
Owner

Abdelrhman-AK commented Jul 12, 2023

  • That is because of the patched basebrd.dll.res file inside the theme pack.
  • WinPaletter gets current OS name from property Computer.Info.OSFullName that mainly depends on basebrd.dll.res.
  • Here you are the difference between original (untouched) basebrd.dll.res and the patched basebrd.dll.res.
    0
  • When I modified every entry that contains Windows 10 or Windows 7 to Windows XP myself, WinPaletter detected that the current OS is Windows XP.
    1
  • Try to restore your system to default by 7tsp, then modify the ZIP theme pack by deleting basebrd.dll.res inside resources directory and finally patch your Windows by the new ZIP.

@Cynosphere
Copy link
Author

Thanks

@Abdelrhman-AK
Copy link
Owner

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue Issue
Projects
None yet
Development

No branches or pull requests

2 participants