Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Generator class #19

Merged
merged 6 commits into from
Aug 29, 2021
Merged

Refactor Generator class #19

merged 6 commits into from
Aug 29, 2021

Conversation

elmkarami
Copy link
Collaborator

What's this PR do?

Split the main Generator class into multiple independent generator
classes

Any background context you want to provide?

Will make it easy to add new functionality to the generator or add new generator classes + independently testable

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

elmkarami and others added 3 commits August 29, 2021 12:55
Split the main Generator class into multiple independant generator
classes
Copy link
Owner

@Abdenasser Abdenasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elmkarami awesome 👍🏻 , please rebase and make test if there is any linting errors make format

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #19 (840e156) into main (c84cd83) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          240       255   +15     
=========================================
+ Hits           240       255   +15     
Impacted Files Coverage Δ
dr_scaffold/generators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84cd83...840e156. Read the comment docs.

Copy link
Owner

@Abdenasser Abdenasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @elmkarami, I really appreciate the time you put on this ... thanks a lot buddy 🥇

@Abdenasser Abdenasser merged commit cc581d6 into Abdenasser:main Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants