Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring #7

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Minor refactoring #7

merged 2 commits into from
Aug 24, 2022

Conversation

andreped
Copy link
Contributor

I was going to test the software, but saw that the README could use some minor refactoring.

Next I will test it on my machine. Will let you know if I have any issues.

BTW: Why haven't you packages the program into an exectuable (and an installer)? That is quite easy to do with PyInstaller. I have done that before for this project:
https://github.com/dbouget/Raidionics

I could setup the CI stuff and the installer, if you'd like, and we could test it :)

@Abe404
Copy link
Owner

Abe404 commented Aug 24, 2022

Thanks Andre.

Regarding the installer. I usually do that, and have a system that works well for it. See https://github.com/Abe404/root_painter

But have not yet had it requested for RootPainter3D. Do you think it's worth me setting it up now? I was thinking to first wait until there was some demand for the installer.

@Abe404
Copy link
Owner

Abe404 commented Aug 24, 2022

If you want to write the installer creation code that is cool. Otherwise I could copy across the relevant code from https://github.com/Abe404/root_painter

Basically I am happy to go with your preference here.

@Abe404 Abe404 merged commit 19cbcfb into Abe404:master Aug 24, 2022
@Abe404
Copy link
Owner

Abe404 commented Aug 24, 2022

I could setup the CI stuff and the installer, if you'd like, and we could test it :)

I am also interested in the CI stuff. Please go ahead with this. Sounds good

@andreped
Copy link
Contributor Author

By having code for installer, you mean this?
https://github.com/Abe404/root_painter/tree/master/painter#mac

I was thinking of using CI. Hence, for each commit (or whenever you prefer) we can test if the software successfully builds and that the installer gets created. We could also setup unit tests.

I can make an issue regarding the CI stuff and try setting up a simple CI workflow.

@Abe404
Copy link
Owner

Abe404 commented Aug 24, 2022

Yes, after setting up the dependencies the build process involves the following three commands:

python src/build/clean.py
python src/build/freeze.py
python src/build/installer.py

I had considered CI but for some reason trusted the slightly more manual process a bit more. I think CI is the right thing to do and am happy you are moving forwards with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants