Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement for segment folder menu? #114

Open
ethanbass opened this issue Jul 26, 2023 · 3 comments
Open

UI improvement for segment folder menu? #114

ethanbass opened this issue Jul 26, 2023 · 3 comments

Comments

@ethanbass
Copy link

ethanbass commented Jul 26, 2023

The segment folder menu currently makes you select the input and output directories manually even though (as far as I can tell), it is sharply constrained by the program what folders you can use for this. I believe the output directory has to be the "segmentation" directory and the input directory has to be the image directory that was already specified when opening the project. It would be convenient (and less confusing) if these were filled in automatically from the project file. Also, if it's easy to do with the widget, I think the model files could be in a drop down menu that pulls up the files from the models folder as options instead of having to navigate the whole file system.

Similarly for the Measurements menus it seems like the segmentation folder could be pre-specified?

All best,
Ethan

@Abe404
Copy link
Owner

Abe404 commented Jul 26, 2023

Hi Ethan,

I agree there’s some room for improvement in terms of more sensible defaults for these options.

I believe the output directory has to be the "segmentation" directory

This is not currently the case. My personal suggestion is to create a “results” folder within each project folder that contains a segmentation folder within it that perhaps also includes the model number in the folder name. For example projects/project_name/results/seg_model_10

Then when you segment a dataset with a specific model you can add the segmentations to the project (in its results folder) which was used for training that model. This is just my suggestion.

The projects/project_name/segmentations folder exists for every project and includes the segmentations created as part of the interactive training procedure. I suggest leaving these as they are (don’t overwrite them) so they can be used for computing metrics etc. I suggest outputting additional segmentations (created when using the segment folder function) into your own user-defined results folder or similar.

I think it would help to have my suggestions as defaults when using the segment folder function from within an open project and also to automatically select the model with the highest number.

It’s currently possible to use the segment folder option without even opening a project. In that case it’s not clear which models, output folders or datasets would be selected. In that case I think there shouldn’t be any defaults.

I think things are a bit more open ended than you believed. Perhaps this helps explain the lack of defaults?

Kind regards,
Abraham

@Abe404
Copy link
Owner

Abe404 commented Jul 26, 2023

Concretely: For segmenting folders while in an open project, I believe model and output directory should be automatically suggested/populated.

Dataset is less clear due to the difference between the training dataset and original images (that the user most likely wants to segment). I think the user has to specify the dataset for now but perhaps this is something to come back to later.

I think the whole “create training dataset” functionality is pretty confusing for many users and should happen more seamlessly behind the scenes without users being aware of it.

@ethanbass
Copy link
Author

ethanbass commented Jul 26, 2023

Yes this makes a lot of sense -- thank you for the clarification. In light of your recommendations I'm even more convinced that it would be helpful to provide some sensible defaults for these parameters. I'm sure the thing about the recommendation about results folder is well documented somewhere, but I think I overlooked it when I was reading through the docs. Perhaps it would make sense to automatically create the results folder when the project is created?

Re: the training dataset -- the way I've been dealing with this is by creating a separate project for the training data and then importing the trained model into a new project for doing the actual analyses, so I don't think I'm overwriting anything by writing the segmentations into the segmentations folder. Do you see any issue with doing it this way? Maybe an easy fix for this confusion would be to add an additional field to the project file, so you could specify two datasets when you start the project -- one for analysis and one for training? Or as you suggest, the training data could be created more automatically from the analysis dataset and both paths could be stored in the project file.

Thanks for all your insights!
Ethan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants