Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search 2 #39

Merged
merged 15 commits into from
Feb 25, 2024
Merged

Feature/search 2 #39

merged 15 commits into from
Feb 25, 2024

Conversation

Abhiek187
Copy link
Owner

@Abhiek187 Abhiek187 commented Feb 25, 2024

ipad-demo.mov

The iOS implementation of Abhiek187/ez-recipes-web#8 & Abhiek187/ez-recipes-web#205.

This is a continuation of #37 and includes the following changes:

  • A similar pattern to the HomeView where we show a ProgressView and then navigate to the search results (with the same loading messages)
    • This involved juggling some stuff between SearchView, FilterForm, and SubmitButton, but I was able to find a way
  • Responsive recipe cards on the results screen
  • Transitioning from the search results to the RecipeView, while passing data between ViewModels
    • In doing so, I removed the need for a global @EnvironmentObject
  • Fixed how async images load so they stay within the specified dimensions
  • A secondary view for iPads
  • Unit tests for the SearchViewModel
  • SearchView UI tests

Compared to the last PR, this part was easier to implement. There might be some other features I can implement, but for the most part, the iOS app is good to go.

@Abhiek187 Abhiek187 added the enhancement New feature or request label Feb 25, 2024
@Abhiek187 Abhiek187 added this to In progress in EZ Recipes via automation Feb 25, 2024
@Abhiek187 Abhiek187 merged commit a45887c into main Feb 25, 2024
6 of 7 checks passed
EZ Recipes automation moved this from In progress to Done Feb 25, 2024
@Abhiek187 Abhiek187 deleted the feature/search branch February 25, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant