Test APIs #48
Merged
Test APIs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhiek187
added
enhancement
|
I forgot that the Docker workflow only uses the Dockerfile, not docker-compose. (Those tests were quick though, I'm impressed!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help remediate issues like #47, I added tests that call the spoonacular API to make sure the responses are valid. There are 5 API tests, where the random endpoint uses 1.06 points each and the recipe ID endpoint uses 1.1 points each. So in total, each
npm testcommand uses 1.06(2) + 1.1(3) = 2.12 + 3.3 = 5.42 points. With 4 workflows, that totals 5.42(4) = 21.68 points out of the 150 I have under the free plan, which is a little tight, but manageable (no more than 6 attempts per day).As expected, most of the API tests failed since the binary string doesn't conform to the custom response types I specified in the
typesfolder. Strangely, the 401 errors did show correctly, maybe because those responses were smaller? Either way, we have a good system to validate if the next Axios update fixes this bug.