Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define missing types (in progress) #6

Closed
wants to merge 1 commit into from
Closed

feat: define missing types (in progress) #6

wants to merge 1 commit into from

Conversation

kuamanet
Copy link

While this is far from being complete, it's a start to enable projects with typescript to start adding your library as a dependency without having tsc compain.

@Abhinandan-Kushwaha
Copy link
Owner

Thanks @kuamanet for this valuable PR.
Please drop a comment here me when it is ready from your side.

@kuamanet
Copy link
Author

Given that the aim is "make it at least compile" the pr is ready for me :)
Types can be improved of course, but I'd merge it to achieve the first step of functionality

@Abhinandan-Kushwaha
Copy link
Owner

Hi @kuamanet
The code deployed on npm was using the branch dualFrameBuilt. This branch was several commits ahead of main, and already has type-related changes.

I just merged it to main.
I apologise for the confusion due to which you might have made redundant changes.

Please take a pull from main. If resolving the conflicts is too cumbersome, consider raising another PR.

Thanks once again.

@kuamanet kuamanet closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants